November 22, 2007

Scriptaculous 1.8.0 will be patched soon

Hi everyone,

Please notice, I will patch scriptaculous 1.8.0 with my drop zone marker as soon as possible. I will also try to have it working with ghosting.

8 comments:

Anonymous said...

Thanks for that. Patching the new version will really help us out. Many thanks too for your work on the original hack.

Anonymous said...

Hi there, great job with the new version - looking forward to getting my hands on the patched version.

chamnap said...

Anyone using this patch code works well? Can you post a link? For me, It seems not worked so well. The calculation of the element is not so accurate with margin and left-top attributes.

Thanks
Chamnap

Tankut Koray said...

Hi,

Hopefully, I will patch 1.8.0 this weekend.

chamnap I remember you posted some test page links, I am not wrong. Can you post some test page links again? I want to test with them also.

Tankut

chamnap said...

Hi tankut,

http://chamnapchhorn.googlepages.com/patched1.1.7.zip

I see another problem when I have 2 sortables on my page. The children of the first sortable each has magin-top: 20px. The children of the second sortable doesn't have a css margin. The second sortable works very well with emptyPlaceMarker, but the first doesn't work correctly on FF.

When I first dragged the second and the first, the second seems to have incorrect position of markzone too.

I have checked your code. I think it is great. The problem realizes on the markEmptyPlace(). I see you use two methods from prototype: Position.cumulativeOffset and Element.getStyle(element, 'margin'). Well, the method Position.cumulativeOffset incorrectly reports the position of my first div of my first sortable. I don't know why.
Element.getStyle(element, 'margin') also reports incorrectly when I code css margin-top: 20px; This method reports to null. But, I code css margin: 20px 0px 0px; it reports correctly.

Well, I'm so young in programming field especially in Javascript. Sometimes I'm afraid of this. It is just my idea only.

Thanks
Chamnap

Ryen said...

Hey Tankut,

Nice work on the patch. It's a good job that you had done. I'm thinking it's better for you to work together with scriptaculous. For example, discuss with him about a minor joint development or etc. (Since he posted your links in his web too...)

Example: you create your javascript class library for your sortable marker as a sortable_marker.js
(Just like how scriptaculous work with prototype).

This enables easier bug tracking and version control of individual javascript classes from different groups. Well, we can also choose to upgrade/downgrade scriptaculous or prototype scripts to match your script.

Just a suggestion... (Although, I think it might be abit more work for you...) Wht do you reckon?

Cristi Balan said...

Hey Tankut,

Mainly just adding to the encouragement group. This patch is a nice addition to the default behavior and I'm hoping it might be added to the official scripty once it behaves properly regarding the other parameters, like ghosting.

Cheers

Tankut Koray said...

I started writing a comment here. But it make to a post:)

See my new post at http://tanrikut.blogspot.com/2007/12/sciptaculous-180-patched-also-ghosting.html
for my comments and link to patch for 1.8.0

Thanks